Export HttpClient class and publish version 3.4.0#73
Merged
ddunkin merged 2 commits intoFacilityApi:masterfrom May 23, 2025
Merged
Export HttpClient class and publish version 3.4.0#73ddunkin merged 2 commits intoFacilityApi:masterfrom
ddunkin merged 2 commits intoFacilityApi:masterfrom
Conversation
ejball
requested changes
May 23, 2025
Contributor
ejball
left a comment
ejball
left a comment
There was a problem hiding this comment.
If we're going to export it, it should have a doc comment (/** ... */), probably the same as createHttpClient.
Also, the constructor should take an IHttpClientOptions.
It's unfortunate that there are now two ways to create the client, but deleting createHttpClient feels like an unnecessary breaking change.
This allows the class to be extended.
ejball
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export the generated HttpClient class to allow for extension. Update the version to 3.4.0 in the project configuration.